Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
comments: add disposeElement to prevent disposable accumulation on te…
…mplate reuse
  • Loading branch information
xingsy97 committed Mar 24, 2026
commit 24e712f33ea2886d163a39abf7610bce9b1872e8
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,11 @@ export class CommentNodeRenderer implements IListRenderer<ITreeNode<CommentNode>
return (state !== undefined) ? getCommentThreadStateIconColor(state, theme) : undefined;
}

disposeElement(_node: ITreeNode<CommentNode>, _index: number, templateData: ICommentThreadTemplateData): void {
templateData.disposables.forEach(d => d.dispose());
templateData.disposables.length = 0;
Comment thread
xingsy97 marked this conversation as resolved.
Outdated
}

disposeTemplate(templateData: ICommentThreadTemplateData): void {
templateData.disposables.forEach(disposeable => disposeable.dispose());
templateData.actionBar.dispose();
Expand Down
Loading