feat: underline active page

[defispartan]

Add underline to active page in navbar

[github-actions]

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page	Size (compressed)
global	477.33 KB (-4 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
/	52.78 KB (🟡 +58 B)	530.11 KB
/faucet	23.73 KB (🟡 +58 B)	501.06 KB
/governance	78.7 KB (🟡 +58 B)	556.04 KB
/governance/proposal	118.29 KB (🟡 +58 B)	595.62 KB
/governance/proposal/[proposalId]	73.11 KB (🟡 +58 B)	550.45 KB
/markets	26.71 KB (🟡 +58 B)	504.04 KB
/reserve-overview	82.85 KB (🟡 +58 B)	560.19 KB
/staking	47.51 KB (🟡 +58 B)	524.84 KB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

[github-actions]

• Ipfs hash: bafybeib6vgaoxnjtsr3jgnbn4vxs7sxa3ax3jrehpfwl44aewsftlc7zzi
• Ipfs preview link: https://bafybeib6vgaoxnjtsr3jgnbn4vxs7sxa3ax3jrehpfwl44aewsftlc7zzi.ipfs.cf-ipfs.com/

[sakulstra]

gimme a few minutes to check sth

[sakulstra]

@defispartan pushed the suggested solution in https://github.com/aave/interface/pull/661/files as it was easier than doing a comment. I think the solution is nicer as it's a generic way to add an active class to links pointing to the current route for all links. Also it seems like oleks already added the styles in here: https://github.com/aave/interface/pull/656/files#diff-0bb4e8916774abdd0e57ec15465883766049631721cec9450ff7b571f4ef676aR63 which will now work again.

[MareskoY]

@sendra QA passed

[defispartan]

@defispartan pushed the suggested solution in https://github.com/aave/interface/pull/661/files as it was easier than doing a comment. I think the solution is nicer as it's a generic way to add an active class to links pointing to the current route for all links. Also it seems like oleks already added the styles in here: https://github.com/aave/interface/pull/656/files#diff-0bb4e8916774abdd0e57ec15465883766049631721cec9450ff7b571f4ef676aR63 which will now work again.

Cool, I like that approach better, I'll close this one