Skip to content

feat: add ETHx Merit campaign#2294

Merged
foodaka merged 3 commits intoaave:mainfrom
AaveChan:feat/add-merit-ethx-campaign
Dec 31, 2024
Merged

feat: add ETHx Merit campaign#2294
foodaka merged 3 commits intoaave:mainfrom
AaveChan:feat/add-merit-ethx-campaign

Conversation

@NandyBa
Copy link
Copy Markdown
Contributor

@NandyBa NandyBa commented Dec 27, 2024

General Changes

  • Add ETHx merit Campaign
  • Update Stader logo

Developer Notes

Campaign is live
Forum post: ARFC Set ACI as Emission Manager for Liquidity Mining Programs


Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

@height
Copy link
Copy Markdown

height Bot commented Dec 27, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface-ez7q ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 1:12pm

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 27, 2024

@NandyBa is attempting to deploy a commit to the Avara Team on Vercel.

A member of the Team first needs to authorize it.

@NandyBa NandyBa changed the title ✨feat: add merit ethx campaign feat: add merit ETHx campaign Dec 27, 2024
@NandyBa NandyBa changed the title feat: add merit ETHx campaign feat: add ETHx Merit campaign Dec 27, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 27, 2024

❌ CI run has failed!
Please see logs at https://github.com/aave/interface/actions/runs/12517925274'

@github-actions
Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 538.96 KB (🟢 -5.73 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 52.32 KB (🟡 +4.53 KB) 591.28 KB
/404 6.95 KB (🔴 +4.42 KB) 545.92 KB
/500 7.38 KB (🔴 +4.4 KB) 546.34 KB
/bridge 40.61 KB (🟡 +4.58 KB) 579.57 KB
/faucet 19.93 KB (🔴 +4.83 KB) 558.89 KB
/governance 89.03 KB (🟡 +4.86 KB) 627.99 KB
/governance/ipfs-preview 102.42 KB (🟡 +4.84 KB) 641.38 KB
/governance/v3/proposal 128.93 KB (🟡 +4.78 KB) 667.89 KB
/history 29.54 KB (🟡 +5.77 KB) 568.5 KB
/markets 32.14 KB (🟡 +4.83 KB) 571.11 KB
/reserve-overview 25.25 KB (🔴 +5.56 KB) 564.21 KB
/staking 28.28 KB (🟡 +5 KB) 567.24 KB
/v3-migration 35.78 KB (🟡 +5.17 KB) 574.74 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@foodaka foodaka merged commit 114e728 into aave:main Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants