Skip to content

chore: update version banner#1658

Merged
grothem merged 2 commits intomainfrom
chore/update-market-header
Jun 27, 2023
Merged

chore: update version banner#1658
grothem merged 2 commits intomainfrom
chore/update-market-header

Conversation

@0x4Graham
Copy link
Copy Markdown
Contributor

General Changes

  • Fixes XYZ bug
  • Adds XYZ feature

Developer Notes

Add any notes here that may be helpful for reviewers.


Author Checklist

Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.

  • The base branch is set to main
  • The title is using Conventional Commit formatting
  • The Github issue has been linked to the PR in the Development section
  • The General Changes section has been filled out
  • Developer Notes have been added (optional)

If the PR is ready for review:

  • The PR is in Open state and not in Draft mode
  • The Ready for Dev Review label has been added

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code style generally follows existing patterns
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)
  • Code changes have been quality checked in the ephemeral URL
  • QA verification has been completed
  • There are two or more approvals from the core team
  • Squash and merge has been checked

@height
Copy link
Copy Markdown

height Bot commented Jun 21, 2023

This pull request has been linked to 1 task:

💡Tip: Add "Close T-12230" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@0x4Graham
Copy link
Copy Markdown
Contributor Author

Link T-12230

@github-actions
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 42.01 KB (🟡 +29 B) 584.52 KB
/404 6.45 KB (🟡 +29 B) 548.96 KB
/500 6.9 KB (🟡 +30 B) 549.42 KB
/faucet 22.93 KB (🟡 +29 B) 565.44 KB
/governance 79.66 KB (🟡 +29 B) 622.17 KB
/governance/ipfs-preview 108 KB (🟡 +29 B) 650.51 KB
/governance/proposal 108.16 KB (🟡 +29 B) 650.67 KB
/governance/proposal/[proposalId] 62.87 KB (🟡 +29 B) 605.38 KB
/history 31.51 KB (🟡 +29 B) 574.03 KB
/markets 17.66 KB (🟡 +29 B) 560.17 KB
/reserve-overview 66.6 KB (🟡 +23 B) 609.11 KB
/staking 21.27 KB (🟡 +23 B) 563.79 KB
/v3-migration 29.3 KB (🟡 +29 B) 571.82 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link
Copy Markdown

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 42.01 KB (🟡 +29 B) 584.52 KB
/404 6.45 KB (🟡 +30 B) 548.96 KB
/500 6.9 KB (🟡 +30 B) 549.42 KB
/faucet 22.93 KB (🟡 +29 B) 565.44 KB
/governance 79.66 KB (🟡 +29 B) 622.17 KB
/governance/ipfs-preview 108 KB (🟡 +29 B) 650.51 KB
/governance/proposal 108.16 KB (🟡 +29 B) 650.67 KB
/governance/proposal/[proposalId] 62.87 KB (🟡 +29 B) 605.38 KB
/history 31.51 KB (🟡 +29 B) 574.03 KB
/markets 17.66 KB (🟡 +29 B) 560.17 KB
/reserve-overview 66.6 KB (🟡 +24 B) 609.11 KB
/staking 21.28 KB (🟡 +24 B) 563.79 KB
/v3-migration 29.3 KB (🟡 +29 B) 571.82 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link
Copy Markdown

@grothem grothem merged commit aa80e62 into main Jun 27, 2023
@grothem grothem deleted the chore/update-market-header branch June 27, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants