chore: ampl warning message and governance page text fix#1288
chore: ampl warning message and governance page text fix#1288defispartan merged 6 commits intomainfrom
Conversation
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Three Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
|
iamanastasia
left a comment
There was a problem hiding this comment.
✅ Change APML warning text.
✅ Include 1 link to the message and make sure it is underlined (=is obviously clickable)
✅ Add same message to AMPL reserve page.
❌ Change same message on Supply TX modal windows.
✅ Mention AMPL FAQ article in Aave docs.
Please adjust warning message in supply tx modal window as well
|
LGTM, @0x4Graham I noticed that translations are not implemented on the AMPL warning message, do you want to do that in scope of this ticket or I can create a separate feature ticket where we will implement translations(Spanish/ French/ Greek) ? |
Supply message fixed on modal. |
|


General Changes
Add AMPL warning message to the reserve overview
Fix "Go back" to "Go Back" in AIP view to match the rest of the app.
Developer Notes
Add any notes here that may be helpful for reviewers.
Author Checklist
Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.
mainIf the PR is ready for review:
Openstate and not inDraftmodeReady for Dev Reviewlabel has been addedReviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files