Skip to content

chore: ampl warning message and governance page text fix#1288

Merged
defispartan merged 6 commits intomainfrom
chore/add-ampl-how-to-messag-warning
Nov 2, 2022
Merged

chore: ampl warning message and governance page text fix#1288
defispartan merged 6 commits intomainfrom
chore/add-ampl-how-to-messag-warning

Conversation

@0x4Graham
Copy link
Copy Markdown
Contributor

@0x4Graham 0x4Graham commented Oct 31, 2022

General Changes

Add AMPL warning message to the reserve overview
Fix "Go back" to "Go Back" in AIP view to match the rest of the app.

Developer Notes

Add any notes here that may be helpful for reviewers.


Author Checklist

Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.

  • The base branch is set to main
  • The title is using Conventional Commit formatting
  • The Github issue has been linked to the PR in the Development section
  • The General Changes section has been filled out
  • Developer Notes have been added (optional)

If the PR is ready for review:

  • The PR is in Open state and not in Draft mode
  • The Ready for Dev Review label has been added

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code style generally follows existing patterns
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)
  • Code changes have been quality checked in the ephemeral URL
  • QA verification has been completed
  • There are two or more approvals from the core team
  • Squash and merge has been checked

@0x4Graham 0x4Graham added the Ready for Dev Review Read for frontend engineer reviews label Oct 31, 2022
@defispartan defispartan removed the question Further information is requested label Oct 31, 2022
@defispartan defispartan added Ready for QA Review Ready for QA engineer reviews and removed Ready for Dev Review Read for frontend engineer reviews labels Oct 31, 2022
defispartan
defispartan previously approved these changes Oct 31, 2022
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 31, 2022

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 513.38 KB (-49 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 38.86 KB (🟢 -142 B) 552.24 KB
/markets 14.31 KB (🟢 -141 B) 527.68 KB
/reserve-overview 63.88 KB (🟡 +43 B) 577.25 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@drewcook drewcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fix

Comment thread src/components/Warnings/AMPLWarning.tsx Outdated
Copy link
Copy Markdown
Contributor

@iamanastasia iamanastasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Change APML warning text.
✅ Include 1 link to the message and make sure it is underlined (=is obviously clickable)
✅ Add same message to AMPL reserve page.
❌ Change same message on Supply TX modal windows.
✅ Mention AMPL FAQ article in Aave docs.

Please adjust warning message in supply tx modal window as well

@bojanaave
Copy link
Copy Markdown
Contributor

LGTM,

Screen Shot 2022-11-01 at 13 41 11

Screen Shot 2022-11-01 at 13 45 32

@0x4Graham I noticed that translations are not implemented on the AMPL warning message, do you want to do that in scope of this ticket or I can create a separate feature ticket where we will implement translations(Spanish/ French/ Greek) ?

@0x4Graham
Copy link
Copy Markdown
Contributor Author

✅ Change APML warning text. ✅ Include 1 link to the message and make sure it is underlined (=is obviously clickable) ✅ Add same message to AMPL reserve page. ❌ Change same message on Supply TX modal windows. ✅ Mention AMPL FAQ article in Aave docs.

Please adjust warning message in supply tx modal window as well

Supply message fixed on modal.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 1, 2022

@defispartan defispartan mentioned this pull request Nov 2, 2022
17 tasks
Copy link
Copy Markdown
Contributor

@drewcook drewcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@defispartan defispartan merged commit 457c2d4 into main Nov 2, 2022
@defispartan defispartan deleted the chore/add-ampl-how-to-messag-warning branch November 2, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready for QA Review Ready for QA engineer reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add AMPL how to message & warning Redirection of the "Go Back" on the details page does not work well on mobile/tablet screen resoultions

5 participants