Validation errors thrown instead of returned in ResultAsync

[mrcattington]

Some errors come back as part of the ExecutionPlan (like InsufficientBalanceError), but others get thrown as InvariantError (like "user has no supply to withdraw").

This means I need both try-catch AND result checking to handle all cases. Would be cleaner if validation errors were returned via ResultAsync.Err instead of thrown.

Is this intentional?

Using @aave/client 0.9.2

[cesarenaldi]

Hey @mrcattington, errors that are modelled in the response are considered possible operating scenarios.

Errors that are thrown are invariants of the system. The request is done outside of the normal operating circumstances. A coding error on the consumer side.

The documentation explains what data to check prior to making any operation. You should perform those preliminary verifications with that data and only commit to the operation if you are within the correct operating circumstances for the operation.

You cannot withdraw if you don't have a supply, you should check that beforehand and only commit to the operation if you do.

[cesarenaldi]

Of course you can alway try-catch for some extra defensive coding (depending on your circumstances), but never rely on the error message wording to interpret the issue. Use it only as a safety net. These messages can change at any time without notice and not be considered a breaking change.