Crash during install of 1.7.27 on MacOS 12.6 `Failed to open juliaup config file.`

[IanButterworth]

% curl -fsSL https://install.julialang.org | sh

info: downloading installer
Welcome to Julia!

This will download and install the official Julia Language distribution
and its version manager Juliaup.

Juliaup will be installed into the Juliaup home directory, located at:

  /Users/ian/.julia/juliaup

The julia, juliaup and other commands will be added to
Juliaup's bin directory, located at:

  /Users/ian/.julia/juliaup/bin

This path will then be added to your PATH environment variable by
modifying the profile files located at:

  /Users/ian/.bashrc
  /Users/ian/.bash_profile
  /Users/ian/.zshrc

Julia will look for a new version of Juliaup itself every 1440 minutes when you start julia.

You can uninstall at any time with juliaup self uninstall and these
changes will be reverted.

✔ Do you want to install with these default configuration choices? · Proceed with installation

Now installing Juliaup
Well, this is embarrassing.

Juliainstaller had a problem and crashed. To help us diagnose the problem you can send us a crash report.
...

name = 'Juliainstaller'
operating_system = 'unix:OSX'
crate_version = '1.7.27'
explanation = '''
Panic occurred in file 'src/operations.rs' at line 675
'''
cause = '''
called `Result::unwrap()` on an `Err` value: Failed to open juliaup config file.

Caused by:
    Permission denied (os error 13)'''
method = 'Panic'
backtrace = '''

   0: 0x103a2df85 - core::result::unwrap_failed::ha988429942445917
   1: 0x1038a9112 - juliaup::command_config_modifypath::run_command_config_modifypath::h1846bc244ac9ea63
   2: 0x1037c296b - juliainstaller::main::h056e9fc82c1547cc
   3: 0x1037ac166 - std::sys_common::backtrace::__rust_begin_short_backtrace::hcb7bab99fdf20ecc
   4: 0x1037ac4f2 - std::rt::lang_start::{{closure}}::h1e9d1356e183e5d3
   5: 0x1037c6f82 - _main'''

rm -rf ~/.julia/juliaup didn't fix it

[IanButterworth]

This appears to be due to .bashrc being locked, which rustup didn't like and gave the error

1) Proceed with installation (default)
2) Customize installation
3) Cancel installation
>1

error: could not amend shell profile: '/Users/ian/.bashrc': could not write rcfile file: '/Users/ian/.bashrc': Permission denied (os error 13)

Recreating the file and running a locally built 1.8.7 gave no error during juliaup add release

However maybe there's more to how the install script works that I didn't test?

[davidanthoff]

This appears to be due to .bashrc being locked

What does that mean? Write protected? Some file lock?

I guess the main question is what the installer should do if it can't modify (for whatever reason) one of the files it needs to modify... I'd say minimally show an error message that says which file is locked and then abort, right?

[IanButterworth]

Yeah. What rustup did was enough to act.

Though there is the question as to whether juliaup or the install script itself is causing the files to be locked, given there are a few reports of this.

[IanButterworth]

So, I had this fixed, but on a clean 1.8.10 install I hit this again.

The extended info pointed to Failed to open file /Users/ian/.zshrc , though it would be nice if the error was served in the UI rather than just in the log file.

...
Now installing Juliaup
Well, this is embarrassing.

Juliainstaller had a problem and crashed. To help us diagnose the problem you can send us a crash report.

We have generated a report file at "/var/folders/_6/1yf6sj0950vcg4t91m9ltb5w0000gn/T/report-9ad602b0-4dd1-4751-99ac-3946a647aa27.toml". Submit an issue or email with the subject of "Juliainstaller Crash Report" and include the report as an attachment.
...
ian@IanMBP-4 ~ % cat /var/folders/_6/1yf6sj0950vcg4t91m9ltb5w0000gn/T/report-9ad602b0-4dd1-4751-99ac-3946a647aa27.toml
name = 'Juliainstaller'
operating_system = 'unix:OSX'
crate_version = '1.8.10'
explanation = '''
Panic occurred in file 'src/operations.rs' at line 713
'''
cause = '''
called `Result::unwrap()` on an `Err` value: Failed to open file /Users/ian/.zshrc.

Caused by:
    Permission denied (os error 13)'''
method = 'Panic'
backtrace = '''

   0: 0x10ea66955 - core::result::unwrap_failed::ha988429942445917
   1: 0x10e8dab52 - juliaup::command_config_modifypath::run_command_config_modifypath::h7518fa9feccdb23a
   2: 0x10e7f3530 - juliainstaller::main::hd91c5cd8b02a81de
   3: 0x10e7dc226 - std::sys_common::backtrace::__rust_begin_short_backtrace::hfd801c676ad497bc
   4: 0x10e7dc5b2 - std::rt::lang_start::{{closure}}::h0858e19c583f02ad
   5: 0x10e7f7b62 - _main'''

Given this has come back, I do wonder whether juliaup is causing these files to be locked

What locking is https://support.apple.com/en-gb/guide/mac-help/mchlp1342/mac#:~:text=To%20protect%20documents%20from%20being,the%20locked%20document%20is%20deleted.

According to lsof the file isn't currently open (opening it manually makes it appear here)

ian@IanMBP-4 ~ % sudo lsof / | grep .zshrc
ian@IanMBP-4 ~ % 

yet I cannot unlock the file even though my user has read & write permissions

[davidanthoff]

Hm, I think the only two functions in juliaup that would touch that file are

juliaup/src/operations.rs

Line 633 in 2104e6a

fn add_path_to_specific_file(bin_path: &PathBuf, path: PathBuf) -> Result<()> {

and

juliaup/src/operations.rs

Line 667 in 2104e6a

fn remove_path_from_specific_file(path: PathBuf) -> Result<()> {

. As far as I can tell none of that would lead to a file lock as you describe? So maybe this is caused by something else?

I think the (minimal) to do for us here is to handle those error conditions properly, though, and not just crash.