[wrangler] Expand telemetry arg allow list to restore dropped boolean flags (#13576)

Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>

Author: MattieTK

.changeset/expand-telemetry-arg-allow-list.md

@@ -0,0 +1,7 @@
+---
+"wrangler": patch
+---
+
+Restore telemetry tracking for common CLI flags that were unintentionally dropped during sanitisation
+
+When argument sanitisation was introduced, only explicitly allow-listed args had their values included in telemetry. The allow list was very conservative, which meant common boolean flags like `--remote`, `--json`, `--dry-run`, `--force`, and many others were no longer being captured in `sanitizedArgs` despite previously being tracked. Boolean flags are inherently safe (values are only `true`/`false`), so these have now been added back to the global allow list. A small number of fixed-choice args (`--local-protocol`, `--upstream-protocol`, `--containers-rollout`) have also been added with their known value sets.

packages/wrangler/src/__tests__/metrics/sanitization.test.ts

@@ -1,6 +1,7 @@
 import { describe, it } from "vitest";
 import {
 	ALLOW,
+	COMMAND_ARG_ALLOW_LIST,
 	getAllowedArgs,
 	REDACT,
 	sanitizeArgKeys,
@@ -134,3 +135,37 @@ describe("getAllowedArgs", () => {
 		expect(r2Result.global).toBe(ALLOW);
 	});
 });
+
+describe("COMMAND_ARG_ALLOW_LIST", () => {
+	it("should pass boolean flag values through the full sanitisation pipeline for any command", ({
+		expect,
+	}) => {
+		// Simulate a user running: wrangler <command> --remote --dry-run --json
+		const args = {
+			remote: true,
+			"dry-run": true,
+			dryRun: true,
+			json: true,
+			$0: "wrangler",
+			_: [],
+		};
+		const argv = [
+			"node",
+			"wrangler",
+			"some-command",
+			"--remote",
+			"--dry-run",
+			"--json",
+		];
+
+		const argsWithSanitizedKeys = sanitizeArgKeys(args, argv);
+		const allowedArgs = getAllowedArgs(COMMAND_ARG_ALLOW_LIST, "some-command");
+		const sanitizedArgs = sanitizeArgValues(argsWithSanitizedKeys, allowedArgs);
+
+		expect(sanitizedArgs).toEqual({
+			remote: true,
+			dryRun: true,
+			json: true,
+		});
+	});
+});

packages/wrangler/src/metrics/sanitization.ts

@@ -48,16 +48,57 @@ export type AllowList = Record<string, AllowedArgs>;
  * - ALLOW: all values for that arg are allowed
  */
 export const COMMAND_ARG_ALLOW_LIST: AllowList = {
-	// * applies to all commands
+	// * applies to all commands.
+	// Boolean flags are inherently safe (values are only true/false).
 	"*": {
 		format: ALLOW,
 		logLevel: ALLOW,
+		json: ALLOW,
+		force: ALLOW,
+		remote: ALLOW,
+		local: ALLOW,
+		dryRun: ALLOW,
+		preview: ALLOW,
+		yes: ALLOW,
+		skipConfirmation: ALLOW,
+		noBundle: ALLOW,
+		bundle: ALLOW,
+		minify: ALLOW,
+		latest: ALLOW,
+		uploadSourceMaps: ALLOW,
+		legacyEnv: ALLOW,
+		liveReload: ALLOW,
+		keepVars: ALLOW,
+		logpush: ALLOW,
+		strict: ALLOW,
+		testScheduled: ALLOW,
+		showInteractiveDevSession: ALLOW,
+		skipCaching: ALLOW,
+		commitDirty: ALLOW,
+		includeRuntime: ALLOW,
+		includeEnv: ALLOW,
+		strictVars: ALLOW,
+		check: ALLOW,
+		useRemote: ALLOW,
+		updateConfig: ALLOW,
+		nodeCompat: ALLOW,
+		enableContainers: ALLOW,
+		xAutoconfig: ALLOW,
+		ignoreDefaults: ALLOW,
 	},
 	tail: { status: ALLOW },
 	types: {
 		xIncludeRuntime: [".wrangler/types/runtime.d.ts"],
 		path: ["worker-configuration.d.ts"],
 	},
+	// Fixed-choice args scoped to their commands.
+	dev: {
+		localProtocol: ["http", "https"],
+		upstreamProtocol: ["http", "https"],
+	},
+	deploy: {
+		containersRollout: ["immediate", "gradual"],
+	},
 };
 
 /**