refactor: replaced the ecrecover with the OZ's ECDSA.recover

Author: TepNik

docs/3.4/Aave-v3.4-features.md

@@ -137,6 +137,7 @@ The implementation for aAAVE was upgraded in line with the other tokens: [AToken
 - VersionedInitializable now bricks the initializer on the implementation, so implementations no longer have to be initialized in order to prevent malicious initialization.
 - Now all fees from flash-loans are sent to the `RESERVE_TREASURY_ADDRESS` in the form of the underlying token. Also, the function `FLASHLOAN_PREMIUM_TO_PROTOCOL` in the `Pool` contract now always returns `100_00` value.
 - Improved the accuracy and gas consumption of the `calculateCompoundedInterest` function without changing the formula. Inside calculations of the `second_term` and `third_term` variables now at first the function performs multiplications by `exp` and then divides by `SECONDS_PER_YEAR`. Previously it was the other way around, first there was division, then multiplication.
+- Replaced the use of the `ecrecover` function call with the OpenZeppelin's `ECDSA.recover` function call.
 
 ## Changelog
 

src/contracts/mocks/testnet-helpers/TestnetERC20.sol

@@ -1,6 +1,8 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.0;
 
+import {ECDSA} from 'openzeppelin-contracts/contracts/utils/cryptography/ECDSA.sol';
+
 import {Ownable} from '../../dependencies/openzeppelin/contracts/Ownable.sol';
 import {ERC20} from '../../dependencies/openzeppelin/contracts/ERC20.sol';
 import {IERC20WithPermit} from '../../interfaces/IERC20WithPermit.sol';
@@ -64,7 +66,7 @@ contract TestnetERC20 is IERC20WithPermit, ERC20, Ownable {
         keccak256(abi.encode(PERMIT_TYPEHASH, owner, spender, value, currentValidNonce, deadline))
       )
     );
-    require(owner == ecrecover(digest, v, r, s), 'INVALID_SIGNATURE');
+    require(owner == ECDSA.recover(digest, v, r, s), 'INVALID_SIGNATURE');
     _nonces[owner] = currentValidNonce + 1;
     _approve(owner, spender, value);
   }

src/contracts/mocks/tokens/MintableERC20.sol

@@ -1,6 +1,8 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.10;
 
+import {ECDSA} from 'openzeppelin-contracts/contracts/utils/cryptography/ECDSA.sol';
+
 import {ERC20} from '../../dependencies/openzeppelin/contracts/ERC20.sol';
 import {IERC20WithPermit} from '../../interfaces/IERC20WithPermit.sol';
 
@@ -56,7 +58,7 @@ contract MintableERC20 is IERC20WithPermit, ERC20 {
         keccak256(abi.encode(PERMIT_TYPEHASH, owner, spender, value, currentValidNonce, deadline))
       )
     );
-    require(owner == ecrecover(digest, v, r, s), 'INVALID_SIGNATURE');
+    require(owner == ECDSA.recover(digest, v, r, s), 'INVALID_SIGNATURE');
     _nonces[owner] = currentValidNonce + 1;
     _approve(owner, spender, value);
   }

src/contracts/protocol/tokenization/AToken.sol

@@ -1,9 +1,11 @@
 // SPDX-License-Identifier: BUSL-1.1
 pragma solidity ^0.8.10;
 
+import {SafeCast} from 'openzeppelin-contracts/contracts/utils/math/SafeCast.sol';
+import {ECDSA} from 'openzeppelin-contracts/contracts/utils/cryptography/ECDSA.sol';
+
 import {IERC20} from '../../dependencies/openzeppelin/contracts/IERC20.sol';
 import {GPv2SafeERC20} from '../../dependencies/gnosis/contracts/GPv2SafeERC20.sol';
-import {SafeCast} from 'openzeppelin-contracts/contracts/utils/math/SafeCast.sol';
 import {VersionedInitializable} from '../../misc/aave-upgradeability/VersionedInitializable.sol';
 import {Errors} from '../libraries/helpers/Errors.sol';
 import {WadRayMath} from '../libraries/math/WadRayMath.sol';
@@ -152,7 +154,7 @@ abstract contract AToken is VersionedInitializable, ScaledBalanceTokenBase, EIP7
         keccak256(abi.encode(PERMIT_TYPEHASH, owner, spender, value, currentValidNonce, deadline))
       )
     );
-    require(owner == ecrecover(digest, v, r, s), Errors.InvalidSignature());
+    require(owner == ECDSA.recover(digest, v, r, s), Errors.InvalidSignature());
     _nonces[owner] = currentValidNonce + 1;
     _approve(owner, spender, value);
   }

src/contracts/protocol/tokenization/base/DebtTokenBase.sol

@@ -1,6 +1,8 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.10;
 
+import {ECDSA} from 'openzeppelin-contracts/contracts/utils/cryptography/ECDSA.sol';
+
 import {Context} from '../../../dependencies/openzeppelin/contracts/Context.sol';
 import {Errors} from '../../libraries/helpers/Errors.sol';
 import {VersionedInitializable} from '../../../misc/aave-upgradeability/VersionedInitializable.sol';
@@ -62,7 +64,7 @@ abstract contract DebtTokenBase is
         )
       )
     );
-    require(delegator == ecrecover(digest, v, r, s), Errors.InvalidSignature());
+    require(delegator == ECDSA.recover(digest, v, r, s), Errors.InvalidSignature());
     _nonces[delegator] = currentValidNonce + 1;
     _approveDelegation(delegator, delegatee, value);
   }

src/contracts/protocol/tokenization/delegation/BaseDelegation.sol

@@ -2,6 +2,7 @@
 pragma solidity ^0.8.0;
 
 import {MessageHashUtils} from 'openzeppelin-contracts/contracts/utils/cryptography/MessageHashUtils.sol';
+import {ECDSA} from 'openzeppelin-contracts/contracts/utils/cryptography/ECDSA.sol';
 import {SafeCast} from 'openzeppelin-contracts/contracts/utils/math/SafeCast.sol';
 
 import {WadRayMath} from '../../libraries/math/WadRayMath.sol';
@@ -166,7 +167,7 @@ abstract contract BaseDelegation is IBaseDelegation {
       )
     );
 
-    require(delegator == ecrecover(digest, v, r, s), Errors.InvalidSignature());
+    require(delegator == ECDSA.recover(digest, v, r, s), Errors.InvalidSignature());
 
     _delegateByType(delegator, delegatee, delegationType);
   }
@@ -191,7 +192,7 @@ abstract contract BaseDelegation is IBaseDelegation {
       )
     );
 
-    require(delegator == ecrecover(digest, v, r, s), Errors.InvalidSignature());
+    require(delegator == ECDSA.recover(digest, v, r, s), Errors.InvalidSignature());
 
     _delegateByType(delegator, delegatee, GovernancePowerType.VOTING);
     _delegateByType(delegator, delegatee, GovernancePowerType.PROPOSITION);