feat: v2 default test (#154)

* refactor: rename v2 playloadbase to v2payload for consistency

* feat: add v2 default test

Author: sakulstra

src/ProtocolV2TestBase.sol

@@ -11,6 +11,7 @@ import {ExtendedAggregatorV2V3Interface} from './interfaces/ExtendedAggregatorV2
 import {CommonTestBase, ReserveTokens} from './CommonTestBase.sol';
 import {ProxyHelpers} from './ProxyHelpers.sol';
 import {ChainIds} from './ChainIds.sol';
+import {GovV3Helpers} from './GovV3Helpers.sol';
 
 struct ReserveConfig {
   string symbol;
@@ -49,6 +50,30 @@ struct InterestStrategyValues {
 contract ProtocolV2TestBase is CommonTestBase {
   using SafeERC20 for IERC20;
 
+  /**
+   * @dev runs the default test suite that should run on any proposal touching the aave protocol which includes:
+   * - diffing the config
+   * - running an e2e testsuite over all assets
+   */
+  function defaultTest(
+    string memory reportName,
+    ILendingPool pool,
+    address payload
+  ) public returns (ReserveConfig[] memory, ReserveConfig[] memory) {
+    string memory beforeString = string(abi.encodePacked(reportName, '_before'));
+    ReserveConfig[] memory configBefore = createConfigurationSnapshot(beforeString, pool);
+
+    GovV3Helpers.executePayload(vm, payload);
+
+    string memory afterString = string(abi.encodePacked(reportName, '_after'));
+    ReserveConfig[] memory configAfter = createConfigurationSnapshot(afterString, pool);
+
+    diffReports(beforeString, afterString);
+
+    e2eTest(pool);
+    return (configBefore, configAfter);
+  }
+
   /**
    * @dev Generates a markdown compatible snapshot of the whole pool configuration into `/reports`.
    * @param reportName filename suffix for the generated reports.

src/ProtocolV3TestBase.sol

@@ -66,6 +66,12 @@ contract ProtocolV3TestBase is CommonTestBase {
   using ReserveConfiguration for DataTypes.ReserveConfigurationMap;
   using SafeERC20 for IERC20;
 
+  /**
+   * @dev runs the default test suite that should run on any proposal touching the aave protocol which includes:
+   * - diffing the config
+   * - checking if the changes are plausible (no conflicting config changes etc)
+   * - running an e2e testsuite over all assets
+   */
   function defaultTest(
     string memory reportName,
     IPool pool,

…c/v2-config-engine/AaveV2PayloadBase.sol src/v2-config-engine/AaveV2Payload.solsrc/v2-config-engine/AaveV2PayloadBase.sol renamed to src/v2-config-engine/AaveV2Payload.sol src/v2-config-engine/AaveV2PayloadBase.sol renamed to src/v2-config-engine/AaveV2Payload.sol

@@ -16,7 +16,7 @@ import {EngineFlags} from '../v3-config-engine/EngineFlags.sol';
  *    Updates of interest rate strategies.
  * @author BGD Labs
  */
-abstract contract AaveV2PayloadBase {
+abstract contract AaveV2Payload {
   using Address for address;
 
   IEngine public immutable LISTING_ENGINE;

src/v2-config-engine/AaveV2PayloadAvalanche.sol

@@ -2,15 +2,13 @@
 pragma solidity ^0.8.0;
 
 import {AaveV2Avalanche} from 'aave-address-book/AaveV2Avalanche.sol';
-import './AaveV2PayloadBase.sol';
+import './AaveV2Payload.sol';
 
 /**
  * @dev Base smart contract for an Aave v2 rates update on Avalanche.
  * @author BGD Labs
  */
 // TODO: Add rates factory address after deploying
-abstract contract AaveV2PayloadAvalanche is
-  AaveV2PayloadBase(IEngine(AaveV2Avalanche.CONFIG_ENGINE))
-{
+abstract contract AaveV2PayloadAvalanche is AaveV2Payload(IEngine(AaveV2Avalanche.CONFIG_ENGINE)) {
 
 }

src/v2-config-engine/AaveV2PayloadEthereum.sol

@@ -2,15 +2,13 @@
 pragma solidity ^0.8.0;
 
 import {AaveV2Ethereum} from 'aave-address-book/AaveV2Ethereum.sol';
-import './AaveV2PayloadBase.sol';
+import './AaveV2Payload.sol';
 
 /**
  * @dev Base smart contract for an Aave v2 rates update on Ethereum.
  * @author BGD Labs
  */
 // TODO: Add rates factory address after deploying
-abstract contract AaveV2PayloadEthereum is
-  AaveV2PayloadBase(IEngine(AaveV2Ethereum.CONFIG_ENGINE))
-{
+abstract contract AaveV2PayloadEthereum is AaveV2Payload(IEngine(AaveV2Ethereum.CONFIG_ENGINE)) {
 
 }

src/v2-config-engine/AaveV2PayloadEthereumAMM.sol

@@ -2,15 +2,15 @@
 pragma solidity ^0.8.0;
 
 import {AaveV2EthereumAMM} from 'aave-address-book/AaveV2EthereumAMM.sol';
-import './AaveV2PayloadBase.sol';
+import './AaveV2Payload.sol';
 
 /**
  * @dev Base smart contract for an Aave v2 rates update on Ethereum.
  * @author BGD Labs
  */
 // TODO: Add rates factory address after deploying
 abstract contract AaveV2PayloadEthereumAMM is
-  AaveV2PayloadBase(IEngine(AaveV2EthereumAMM.CONFIG_ENGINE))
+  AaveV2Payload(IEngine(AaveV2EthereumAMM.CONFIG_ENGINE))
 {
 
 }

src/v2-config-engine/AaveV2PayloadPolygon.sol

@@ -2,13 +2,13 @@
 pragma solidity ^0.8.0;
 
 import {AaveV2Polygon} from 'aave-address-book/AaveV2Polygon.sol';
-import './AaveV2PayloadBase.sol';
+import './AaveV2Payload.sol';
 
 /**
  * @dev Base smart contract for an Aave v2 rates update on Avalanche.
  * @author BGD Labs
  */
 // TODO: Add rates factory address after deploying
-abstract contract AaveV2PayloadPolygon is AaveV2PayloadBase(IEngine(AaveV2Polygon.CONFIG_ENGINE)) {
+abstract contract AaveV2PayloadPolygon is AaveV2Payload(IEngine(AaveV2Polygon.CONFIG_ENGINE)) {
 
 }

src/v2-config-engine/IAaveV2ConfigEngine.sol

@@ -4,7 +4,7 @@ pragma solidity ^0.8.0;
 import {ILendingPoolConfigurator} from 'aave-address-book/AaveV2.sol';
 import {IV2RateStrategyFactory} from './IV2RateStrategyFactory.sol';
 
-/// @dev Examples here assume the usage of the `AaveV2PayloadBase` base contracts
+/// @dev Examples here assume the usage of the `AaveV2Payload` base contracts
 /// contained in this same repository
 interface IAaveV2ConfigEngine {
   /**
@@ -49,5 +49,4 @@ interface IAaveV2ConfigEngine {
   function RATE_STRATEGIES_FACTORY() external view returns (IV2RateStrategyFactory);
 
   function POOL_CONFIGURATOR() external view returns (ILendingPoolConfigurator);
-
 }

tests/mocks/AaveV2EthereumRatesUpdate.sol

@@ -1,16 +1,16 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.0;
 
-import '../../src/v2-config-engine/AaveV2PayloadBase.sol';
+import '../../src/v2-config-engine/AaveV2Payload.sol';
 import {AaveV2EthereumAssets} from 'aave-address-book/AaveV2Ethereum.sol';
 
 /**
  * @dev Smart contract for a mock rates update, for testing purposes
  * IMPORTANT Parameters are pseudo-random, DON'T USE THIS ANYHOW IN PRODUCTION
  * @author BGD Labs
  */
-contract AaveV2EthereumRatesUpdate is AaveV2PayloadBase {
-  constructor(IEngine customEngine) AaveV2PayloadBase(customEngine) {}
+contract AaveV2EthereumRatesUpdate is AaveV2Payload {
+  constructor(IEngine customEngine) AaveV2Payload(customEngine) {}
 
   function rateStrategiesUpdates()
     public