Resolve all warnings and prettified (#278)

Author: kyzia551

scripts/AaveV3ConfigEngine.s.sol

@@ -322,7 +322,7 @@ library DeployEngineBnbLib {
 }
 
 library DeployEngineScrollLib {
-    function deploy() internal returns (address) {
+  function deploy() internal returns (address) {
     IEngine.EngineLibraries memory engineLibraries = IEngine.EngineLibraries({
       listingEngine: Create2Utils.create2Deploy('v1', type(ListingEngine).creationCode),
       eModeEngine: Create2Utils.create2Deploy('v1', type(EModeEngine).creationCode),
@@ -354,7 +354,6 @@ library DeployEngineScrollLib {
   }
 }
 
-
 library DeployEngineZkEvmLib {
   function deploy() internal returns (address) {
     IEngine.EngineLibraries memory engineLibraries = IEngine.EngineLibraries({

src/ChainIds.sol

@@ -47,7 +47,7 @@ library ChainHelpers {
       newFork = vm.createSelectFork(vm.rpcUrl('base'));
     } else if (chainId == ChainIds.GNOSIS) {
       newFork = vm.createSelectFork(vm.rpcUrl('gnosis'));
-    }  else if (chainId == ChainIds.SCROLL) {
+    } else if (chainId == ChainIds.SCROLL) {
       newFork = vm.createSelectFork(vm.rpcUrl('scroll'));
     } else if (chainId == ChainIds.ARBITRUM) {
       newFork = vm.createSelectFork(vm.rpcUrl('arbitrum'));

src/GovV3Helpers.sol

@@ -866,7 +866,7 @@ library GovV3StorageHelpers {
   function injectProposal(
     Vm vm,
     PayloadsControllerUtils.Payload[] memory payloads,
-    address votingPortal
+    address // supposed to be votingPortal, kept to not introduce breaking change, but mute compilation warning
   ) internal returns (uint256) {
     uint256 count = GovernanceV3Ethereum.GOVERNANCE.getProposalsCount();
     uint256 proposalBaseSlot = StorageHelpers.getStorageSlotUintMapping(PROPOSALS_SLOT, count);

src/bridges/AavePolEthERC20Bridge.sol

@@ -100,7 +100,7 @@ contract AavePolEthERC20Bridge is Ownable, Rescuable, IAavePolEthERC20Bridge {
   receive() external payable {
     if (block.chainid != ChainIds.MAINNET) revert InvalidChain();
 
-    (bool success, ) = address(AaveV3Ethereum.COLLECTOR).call{value: address(this).balance}("");
+    (bool success, ) = address(AaveV3Ethereum.COLLECTOR).call{value: address(this).balance}('');
     if (!success) {
       emit FailedToSendETH();
     }

src/dependencies/DefaultReserveInterestRateStrategy.sol

@@ -56,21 +56,21 @@ contract DefaultReserveInterestRateStrategy is IReserveInterestRateStrategy {
 
   constructor(
     ILendingPoolAddressesProvider provider,
-    uint256 optimalUtilizationRate,
-    uint256 baseVariableBorrowRate,
-    uint256 variableRateSlope1,
-    uint256 variableRateSlope2,
-    uint256 stableRateSlope1,
-    uint256 stableRateSlope2
-  ) public {
-    OPTIMAL_UTILIZATION_RATE = optimalUtilizationRate;
-    EXCESS_UTILIZATION_RATE = WadRayMath.ray().sub(optimalUtilizationRate);
+    uint256 optimalUtilizationRate_,
+    uint256 baseVariableBorrowRate_,
+    uint256 variableRateSlope1_,
+    uint256 variableRateSlope2_,
+    uint256 stableRateSlope1_,
+    uint256 stableRateSlope2_
+  ) {
+    OPTIMAL_UTILIZATION_RATE = optimalUtilizationRate_;
+    EXCESS_UTILIZATION_RATE = WadRayMath.ray().sub(optimalUtilizationRate_);
     addressesProvider = provider;
-    _baseVariableBorrowRate = baseVariableBorrowRate;
-    _variableRateSlope1 = variableRateSlope1;
-    _variableRateSlope2 = variableRateSlope2;
-    _stableRateSlope1 = stableRateSlope1;
-    _stableRateSlope2 = stableRateSlope2;
+    _baseVariableBorrowRate = baseVariableBorrowRate_;
+    _variableRateSlope1 = variableRateSlope1_;
+    _variableRateSlope2 = variableRateSlope2_;
+    _stableRateSlope1 = stableRateSlope1_;
+    _stableRateSlope2 = stableRateSlope2_;
   }
 
   function variableRateSlope1() external view returns (uint256) {

src/v2-config-engine/README.md

@@ -23,4 +23,5 @@ If you want to change interest rates strategy, you only need to define the rates
 The `Base Aave v2 Payload` defines `_preExecute()` and `_postExecute()` hook functions, that you can redefine on your payload and will the execute before and after all changes you define.
 
 ## Links to examples
+
 - [Simple rates updates (changing some, keeping current values on others) on Aave v2 Ethereum](../test/mocks/AaveV2EthereumRatesUpdate.sol)

src/v3-config-engine/AaveV3PayloadPolygonZkEvm.sol

@@ -8,7 +8,9 @@ import './AaveV3Payload.sol';
  * @dev Base smart contract for an Aave v3.0.1 (compatible with 3.0.0) listing on v3 Polygon ZkEvm.
  * @author BGD Labs
  */
-abstract contract AaveV3PayloadPolygonZkEvm is AaveV3Payload(IEngine(AaveV3PolygonZkEvm.CONFIG_ENGINE)) {
+abstract contract AaveV3PayloadPolygonZkEvm is
+  AaveV3Payload(IEngine(AaveV3PolygonZkEvm.CONFIG_ENGINE))
+{
   function getPoolContext() public pure override returns (IEngine.PoolContext memory) {
     return IEngine.PoolContext({networkName: 'PolygonZkEvm', networkAbbreviation: 'PolZkEvm'});
   }

src/v3-config-engine/README.md

@@ -33,7 +33,7 @@ Change eMode category of a particular asset? Same as previous, just define the u
 ### Internal aspects to consider
 
 - Frequently, at the same time that you want to do an update of parameters or listing, you also want to do something extra before or after.
-The `Base Aave v3 Payload` defines `_preExecute()` and `_postExecute()` hook functions, that you can redefine on your payload and will the execute before and after all configs changes/listings you define.
+  The `Base Aave v3 Payload` defines `_preExecute()` and `_postExecute()` hook functions, that you can redefine on your payload and will the execute before and after all configs changes/listings you define.
 
 - The payload also allow you to group changes of parameters and listings, just by defining at the same time the aforementioned `newListings()`, `capsUpdate()` and/or `collateralsUpdates()` and so on. For reference, the execution ordering is the following:
   1. `_preExecute()`
@@ -49,6 +49,7 @@ The `Base Aave v3 Payload` defines `_preExecute()` and `_postExecute()` hook fun
   11. `_postExecute()`
 
 ## Links to examples
+
 - [Simple mock listing on Aave v3 Polygon](../test/mocks/AaveV3PolygonMockListing.sol)
 - [Simple custom mock listing on Aave V3 Ethereum with custom token impl](../test/mocks/AaveV3EthereumMockCustomListing.sol)
 - [Mock e-mode category update on Aave V3 Polygon](../test/mocks/AaveV3PolygonEModeCategoryUpdate.sol)

tests/CommonTestBase.t.sol

@@ -10,7 +10,7 @@ contract CommonTestBaseTest is CommonTestBase {
     vm.createSelectFork('mainnet', 18572478);
   }
 
-  function call() external returns (address) {
+  function call() external view returns (address) {
     return msg.sender;
   }
 

tests/PreviewLink.t.sol

@@ -5,7 +5,7 @@ import 'forge-std/Test.sol';
 import {GovV3Helpers, PayloadsControllerUtils} from '../src/GovV3Helpers.sol';
 
 contract PreviewLink is Test {
-  function testPreviewLink() public {
+  function testPreviewLink() public pure {
     PayloadsControllerUtils.Payload[] memory payloads = new PayloadsControllerUtils.Payload[](2);
     payloads[0].payloadId = 1;
     payloads[0].accessLevel = PayloadsControllerUtils.AccessControl.Level_1;